docker/containerd-packaging

Packaged containerd doesn't include container metrics - likely built incorrectly

dhiltgen opened this issue · 1 comments

When I tried to turn on metrics support in containerd, it was missing container level metrics. I'm not sure exactly what's wrong, but one possibility is the fact that we're not using the upstream makefile and all its settings might mean things are being pulled together incorrectly.

Specifically https://github.com/docker/containerd-packaging/blob/master/debian/rules#L12 seems like it's a lot simpler than https://github.com/containerd/containerd/blob/master/Makefile and is perhaps missing some important piece of logic.

Would it make sense to adjust the packaging to use the built-in makefile and just override the install prefix for packaging use?

Closed with #15