Sort volumes by size correctly

Question

Sort volumes by size correctly

Closed this issue 2 years ago · 5 comments

Describe the bug
Sorting by size is not correct.

Add the steps to reproduce
Steps to reproduce the behavior:

Go to the Volumes Backup & Share extension.
Click on the Size header column.
See the volumes are sorted incorrectly.

Describe the expected behavior
The volumes should be sorted correctly depending on their size (including the unit, not just the numeric value).

Optional: Add screenshots

Output of docker extension version:

Client Version: v0.2.13
Server API Version: 0.3.0

Output of docker version:

(paste your output here)

Include extension console logs
If relevant, you can add console logs that might include some trace related to the bug you're reporting

Additional context
Add any other context about the problem here.

Answer 1 · 2022-10-20T16:31:42.000Z

Hi @felipecruz91 , It seems doable to me! Can you please assign this one to me?

Answer 2 · 2022-10-21T10:29:23.000Z

Hey @felipecruz91, I found out that this project uses mui data grid pro so do you guys have a demo key or something or should I just use regular data grid while developing?

Answer 3 · 2022-10-21T12:15:53.000Z

Hi @Lalit3716, just use any dummy value for the key. You'll see a watermark on the extension as a result. That shouldn't block you from developing 😄

Answer 4 · 2022-10-21T13:25:33.000Z

Oh I see thanks for clarifying that I will start the work right away!

Answer 5 · 2022-11-01T05:46:09.000Z

Hi @felipecruz91, can you kindly review this PR it's been there for quite some time now 😅?