Sort volumes by size correctly
Closed this issue · 5 comments
Describe the bug
Sorting by size is not correct.
Add the steps to reproduce
Steps to reproduce the behavior:
- Go to the Volumes Backup & Share extension.
- Click on the
Size
header column. - See the volumes are sorted incorrectly.
Describe the expected behavior
The volumes should be sorted correctly depending on their size (including the unit, not just the numeric value).
Output of docker extension version
:
Client Version: v0.2.13
Server API Version: 0.3.0
Output of docker version
:
(paste your output here)
Include extension console logs
If relevant, you can add console logs that might include some trace related to the bug you're reporting
Additional context
Add any other context about the problem here.
Hi @felipecruz91 , It seems doable to me! Can you please assign this one to me?
Hey @felipecruz91, I found out that this project uses mui data grid pro so do you guys have a demo key or something or should I just use regular data grid while developing?
Hi @Lalit3716, just use any dummy value for the key. You'll see a watermark on the extension as a result. That shouldn't block you from developing 😄
Oh I see thanks for clarifying that I will start the work right away!
Hi @felipecruz91, can you kindly review this PR it's been there for quite some time now 😅?