README.md proxy port mismatch
Closed this issue · 2 comments
The README.md
has a port mismatch between the text here:
Lines 41 to 42 in f0ff602
And the ports defined here:
compose-dev-env/docker-compose.yaml
Lines 20 to 25 in f0ff602
and here:
compose-dev-env/.docker/docker-compose.yaml
Lines 28 to 33 in f0ff602
The change in #6 updated the port mapping in README.md
and in .docker/docker-compose-yaml
but didn't update the ports in the root-leveldocker-compose.yaml
file.
This causes the instructions in "Deploy with docker-compose" to be wrong, as following:
Lines 44 to 47 in f0ff602
Will use the root level docker-compose.yaml
, causing the proxy to be exposed on port 80, not 8080, as suggested in the section "Expected result":
Line 71 in f0ff602
The fix is presumably a one line change in the proxy ports of docker-compose.yaml
to match those in .docker/docker-compose.yaml
?
Amazingly organized and detailed report. I usually go to issues before PRs, so kudos to you for creating a clear explanation. 💯
Just a gentle nudge to @glours , since this is so little effort to fix but potentially so confusing to less-experienced users who only experience the directions not working for them, and may not realize that there are two nearly-identical files with the same name in different directories.
If there are tedious legal hoops that contributors need to go through, feel free to just reject this PR and take a fix from someone who's already a contributor. 😉