dockersamples/compose-dev-env

README.md proxy port mismatch

Closed this issue · 2 comments

The README.md has a port mismatch between the text here:

When deploying the application, docker-compose maps port 80 of the proxy service container to port 8080 of the host as specified in the file.
Make sure port 8080 on the host is not already being in use.

And the ports defined here:

proxy:
build: proxy
ports:
- 80:80
depends_on:
- backend

and here:

proxy:
build: proxy
ports:
- 8080:80
depends_on:
- backend

The change in #6 updated the port mapping in README.md and in .docker/docker-compose-yaml but didn't update the ports in the root-leveldocker-compose.yaml file.

This causes the instructions in "Deploy with docker-compose" to be wrong, as following:

## Deploy with docker-compose
```
$ docker-compose up -d

Will use the root level docker-compose.yaml, causing the proxy to be exposed on port 80, not 8080, as suggested in the section "Expected result":

After the application starts, navigate to `http://localhost:8080` in your web browser or run:

The fix is presumably a one line change in the proxy ports of docker-compose.yaml to match those in .docker/docker-compose.yaml?

Amazingly organized and detailed report. I usually go to issues before PRs, so kudos to you for creating a clear explanation. 💯

Just a gentle nudge to @glours , since this is so little effort to fix but potentially so confusing to less-experienced users who only experience the directions not working for them, and may not realize that there are two nearly-identical files with the same name in different directories.

If there are tedious legal hoops that contributors need to go through, feel free to just reject this PR and take a fix from someone who's already a contributor. 😉