Incorrect name and no state is defined for the ‘Hamburger’ menu button.
Closed this issue · 2 comments
Bug Report
Steps to reproduce
- Open the URL: PWABuilder - Packaging for the Google Play Store in browser.
- Turn on the narrator through Ctrl+ Windows+ Enter key.
- Navigate to the hamburger menu through tab key.
- Observe the issue.
Current behaviour
Incorrect name and no state are defined for the ‘Hamburger’ menu button, Screen reader is only announcing as ‘Menu button.
Attachments:
Incorrect.name.and.no.state.is.defined.for.the.Hamburger.menu.button.3.1.mp4
Expected behaviour
Proper name and state should be defined for the ‘Hamburger’ menu button.Screen reader should announce as ‘Hamburger menu’ button 'collapsed’ when it is in collapsed state and expanded when it is in expanded state.
Other relevant information
- Docsify version: 4.4.4
-
[ X] Bug still occurs when all/other plugins are disabled?
-
Docsify plugins (if the bug happens when plugins enabled, please try to isolate the issue): NA
Please create a reproducible sandbox
Mention the docsify version in which this bug was not present (if any)
NA
Thanks very much for reporting this issue @msftedad . Re: un-merged PR #2304 might it still be possible to consider the status 'collapsed' and 'expanded' to the aria-labels for the hamburger menu element @jhildenbiddle ?
Perhaps another option instead of using a UI element name (which might not be familiar to all users) something more action-related like "Expand sidebar, button" and "Collapse sidebar, button" might be label options to consider?
Fixed via #2254.
These updates will be available in the next release. Until then, you can verify the changes by visiting the develop branch preview.