doctrine/sql-formatter

Remove public properties

greg0ire opened this issue · 5 comments

greg0ire commented
Remove public properties
goetas commented

I suggest to mark as private also removeComments() and splitQuery() currently public

  • 👍1
goetas commented

I suggest to mark as private also removeComments() and splitQuery() currently public

looking better, they are not used at all, so I guess can be just removed

  • 🎉1
greg0ire commented

looking better, they are not used at all, so I guess can be just removed

wait 🤔 both are mentioned in the README, why did you want to mark them as private? I think they are deliberately part of the public API

goetas commented

I think they are deliberately part of the public API

yes, but IMO they have nothing to do with this LIB

greg0ire commented

Good point at least about splitQuery!

sql-formatter/README.md

Line 138 in 4db282d

Another feature, which is unrelated to formatting, is the ability to break up a

I think you're right, let's remove those.