doctrine/sql-formatter

Prefer mbstring functions

greg0ire opened this issue · 2 comments

greg0ire commented

See jdorn/sql-formatter#85

Not sure why our coding standard does not enforce that, maybe it's too risky?

goetas commented

Not sure if is a good idea, mb functions seems to be slower. When matching non utf8 characters, ordinary functions should be enough. Is there a case where mb is required?

greg0ire commented

It's indeed consistently slower (according to tests/performance.php), and I tried to build a failing test case from http://baldi.me/blog/emoji-in-sql … no dice. Let's just close this one.