dodyg/practical-aspnetcore

Write simple samples for YARP

dodyg opened this issue · 13 comments

dodyg commented
Write simple samples for YARP

i will take this.

@dodyg can you add this to the project , assign it to my name and out it to inprogress.

On a side note: you can make me a contributor. then i can assign it myself and set its status. Let me know

@dodyg YARP team has a bunch of samples on github. Here is the link: https://github.com/microsoft/reverse-proxy/tree/main/samples

Do we need everything copied here to practical-aspnetcore ?

What should be the path to the sample: projects/reverse-proxy/basic-yarp-sample

dodyg commented

What should be the path to the sample: projects/reverse-proxy/basic-yarp-sample

projects/yarp is better and straightforward

dodyg commented

Do we need everything copied here to practical-aspnetcore ?

https://github.com/microsoft/reverse-proxy/tree/main/samples/ReverseProxy.Minimal.Sample

This is nice but it needs to go simpler. We need to pair it with a running hello world that you can just run and test the proxy with.

dodyg commented

On a side note: you can make me a contributor. then i can assign it myself and set its status. Let me know

done

What should be the path to the sample: projects/reverse-proxy/basic-yarp-sample

projects/yarp is better and straightforward

Well.... Reverse proxy is the concept. YARP is one of the software/package that let's you do it...

dodyg commented

yeah but realistically we are not going to add samples for other packages/tech that is not YARP such as NGINX, HAProxy...

Do we need everything copied here to practical-aspnetcore ?

https://github.com/microsoft/reverse-proxy/tree/main/samples/ReverseProxy.Minimal.Sample

This is nice but it needs to go simpler. We need to pair it with a running hello world that you can just run and test the proxy with.

How about:

the yarp minimal sample demo is possible only with net6.0 preview 4. If we want to do the minimal sample for yarp - this will need to be in projects/net6/yarp. else if we go the old Startup way this can be in projects/yarp ...

@dodyg what do you think ?

dodyg commented

net6/yarp for now. Then when net6 is launched we move it to /projects/

PR created - #296