dojoengine/dojo

remove `SequencerConfig` usage

tcoratger opened this issue · 6 comments

SequencerConfig is marked as in the process of removal in

// TODO: just a placeholder for now, remove until we have a dedicated class for building node
// components
#[deprecated = "In the process of removal"]
#[derive(Debug, Default)]
pub struct SequencerConfig {
pub block_time: Option<u64>,
pub no_mining: bool,
#[cfg(feature = "messaging")]
pub messaging: Option<crate::service::messaging::MessagingConfig>,
}

There are still a few places in the code where this structure is used, for example here:

pub async fn start(config: SequencerConfig, starknet_config: StarknetConfig) -> Self {

In order to fully deprecate this type, we need to remove uses like this.

I will like to work on this

I will like to work on this

hey @Jonatan-Chaverri, im still figuring out that part as i refactor stuff around. so not really thinking of opening it to external contributor for now.

if you want to contribute, i'd suggest trying this one instead #2458

@tcoratger can i take up this issue

@tcoratger want to work on this issue assign it to me

@ScottyDavies @Sagar-Puniyani sorry guys, we're not accepting external contributors for this issue for now.

the entire config management has been revamped here #2508