dolfinus/DarkVector

Redlinks do not seem to render properly

copperwater opened this issue · 3 comments

I'm an editor on a wiki that's recently added the darkvector skin. It doesn't look like red links (to nonexistent pages) render properly; they render the same orange as everything else, which makes browsing confusing. It looks like this is due to the !important in darkvector.less

DarkVector/darkvector.less

Lines 235 to 240 in e981ba2

a,
.mw-body a.external,
.mw-body a.extiw,
.uls-language-list a {
color: #e69710 !important;
}

which overrides other styles on a elements. One can hack their way around this by editing MediaWiki:Darkvector.css with a a.new { color:red !important } or similar, but fighting !important with !important is a bad way to go about it.

I notice that darkvector.less already contains

DarkVector/darkvector.less

Lines 248 to 251 in e981ba2

a.new,
#p-personal a.new {
color: #d44
}

but the !important on all a elements overrides this.

Hello.

I've made a change:
25f94f1

Could you try, please?

Yes, this looks like it works now; redlinks are red by default without requiring any additional CSS in the mediawiki namespace.

Great, thank you!