kdb+ plugin uses unsafe C++ code
Opened this issue · 2 comments
FlyingOE commented
Assigning the result of str.c_str() to a pointer to be used later is against the C++ standard and is not safe. For example:
DolphinDBPlugin/kdb/src/kdb.cpp
Line 61 in 30535a5
FlyingOE commented
There is also potential memory leak upon initial qIPC call in kdb::loadTable
:
DolphinDBPlugin/kdb/src/kdb.cpp
Line 95 in 6bbadf9
DolphinDBPlugin/kdb/src/kdb.cpp
Line 108 in 6bbadf9
FlyingOE commented
This is not exception-safe:
DolphinDBPlugin/kdb/src/kdb.cpp
Line 1307 in 6bbadf9