dominikbulaj/react-scroll-into-view

Default styles

Closed this issue · 2 comments

0FilipK commented

Hello,

are you sure that default style are needed? It's hard to override this and you cannot event apply custom className because you don't pass this props. In my case I was forced to use display: block !important in css or do it in "anti-DRY" way and write style={{display: 'block'}} multiple times.

Is it not a better option to let users define this manually or give them opportunity to disable default styles (like disableDefaultStyles={true})?

dominikbulaj commented

Thanks. I will check it (disable default styles) and allow providing className too. Stay tuned :)

  • 👍1