dominique-mueller/web-extension-github-travis-status

PR review request in url breaks the extension

Closed this issue · 3 comments

TimvdLippe commented

If a link to a PR review request is included in the url, the extension does not load. For example Polymer/tools#281 (review) does not work, while Polymer/tools#281 works. Note that Polymer/tools#281 (comment) also does not work, so I think only a direct link works.

I think

web-extension-github-travis-status/src/background/background.ts

Line 65 in a5b462e

return /^https:\/\/github\.com\/.+\/.+\/pull\/\d+$/.test( url );
should be updated to

/^https:\/\/github\.com\/.+\/.+\/pull\/\d+.+$/.test( url );

or

/^https:\/\/github\.com\/.+\/.+\/pull\/\d+/.test( url );
dominique-mueller commented

Thanks for opening the issue, seems you're right. Feel free to open a PR, otherwhise I'll work on it on some of the next few days.

dominique-mueller commented

Just published version 1.1.1, should be available in the Chrome Web Store within the next few minutes.

TimvdLippe commented

I can confirm it has been fixed 🎉

  • 🎉1