Path should not be closed if it has stroke

Question

Path should not be closed if it has stroke

ljadrbln opened this issue 2 years ago · 14 comments

ljadrbln commented 2 years ago

Hello,

If svg contains unclosed path and if this path has a stroke in the generated PDF path will be closed:

SVG:

PDF:

Answer 1 · 2022-11-21T12:43:09.000Z

Thought this issue was fixed with the last release of php-svg-lib (7926073) but obviously missed something.

Answer 2 · 2023-01-05T08:29:17.000Z

Is there an ETA on this?

Answer 3 · 2023-01-05T14:53:27.000Z

Not yet. I'm trying to finish up the next release of Dompdf then I'll turn my attention to the next php-svg-lib release.

Answer 4 · 2023-01-05T14:59:59.000Z

Ah, the issue is with some missing logic that was not put into the Dompdf version of Cpdf, 😞. So this issue will be fixed with the next Dompdf release.

Answer 5 · 2023-01-05T15:01:13.000Z

That's amazing news! What kind of deadline are we looking at ?

Answer 6 · 2023-01-05T15:03:30.000Z

Still can't say? I'd like to finish up over the next few weeks if possible. I'm in the process of reviewing issues assigned to the next Dompdf release to see what's reasonable to include vs push to the next release.

Answer 7 · 2023-01-05T15:04:51.000Z

Ok, I'm not sure I have the necessary skills to help out here, but if there is some documentation or anything I could look at to PR the thing, feel free to let me know

Answer 8 · 2023-01-05T15:05:59.000Z

I just merged the fix into the main branch so if you want it now you can reference dev-master (if your project setup allows for that).

Answer 9 · 2023-01-05T15:13:25.000Z

Thanks. I guess it won't be easy as we use barryvdh/laravel-dompdf, I think we will have to wait as this package explicitly required ^2 of DomPdf.

Answer 10 · 2023-01-05T16:00:28.000Z

It's possible via Composer configuration by redefining the version reference though I'd have to play around with it to remind myself how to set it up.

Answer 11 · 2023-01-07T08:19:06.000Z

I tried to play around with composer but no luck so far

Answer 12 · 2023-01-07T16:23:42.000Z

The current version of laravel-dompdf specifies "^2.0.1" so assuming you're using it I think you could do something like:

{
    "require": {
        "barryvdh/laravel-dompdf": "^2.0.1",
        "dompdf/dompdf": "dev-master as 2.0.1.1"
    }
}

You'll want to remove that alias at some point, but it won't interfere with future release of Dompdf since we don't version that deep.

Answer 13 · 2023-01-17T14:43:55.000Z

It works indeed! Thank you so much for that!

Answer 14 · 2023-02-04T17:30:03.000Z

FYI Dompdf 2.0.2 was released that includes the updates for the Cpdf library.