Advertising error
Closed this issue · 10 comments
Just discovered a weird advertising(?) error I cannot figure out myself.
I'm trying to advertise this shortened url (a personalised bitly domain):
http://nigh.pw/1LPkaFc
but it doesn't get picked up by any Physical Web scanner.
If I change it to:
http://bit.ly/1LPkaFc
it works.
The actual eddystone URL data looks the same after encoding and decoding, so it must be something else? Works without problems on a real beacon.
Same problem with other custom bitly domains.
http://birch.ly/1VAcmLZ doesn't advertise correctly, but http://bit.ly/1VAcmLZ does.
This makes it look like it's got nothing to do with advertising, but the custom domains work fine on real beacons.
@dermike were you using it on OS X?
Try the latest, http://nigh.pw/1LPkaFc and http://birch.ly/1VAcmLZ work for me.
OS X was adding an extra set of GAP flags to the advertisement, I've made some changes to remove it.
Yes, OS X. Will try the new one, thanks!
Ok, I just pushed the changes to Github, will be publishing v1.0 to npm later today.
Feedback is welcome!
@dermike can we close this?
I guess so, can't test myself until tomorrow, I believe you it's fixed ;)
@dermike sounds good, once you've tested, I think it's ready to publish version 1.0 to npm :)
@sandeepmistry working, ship it! :)
@dermike sweet, version 1.0 published to npm.
@sandeepmistry Thank for great job!