donovan-h-parks/biolib

Possible improvement for method 'alphanumeric_sort'

Opened this issue · 1 comments

Greetings!
I noticed that method alphanumeric_sort referred a StackOverflow post, while a recent comment to it noticed that it doesn't work for sorting sets of version numbers alphanumerically; e.g., v1.0.1, v3.5.3, v3.2.4.
I'm trying to learn the usefulness of such small updates on StackOverflow. Would this comment help improve your code? I understand that might not happen in real life situation. In that case, do you think this comment can help prevent future defect (if the code were reused somwhere else)?
I'll really appreciate it if you could kindly give me some feedback or suggestions. Thank you very much for your time.
Have a nice day!

It is nice to know about such updates. It is relevant to my use case and it is unclear that a function claiming to do alphanumeric sorting should handle semantic versioning, but again it certainly doesn't hurt to know about such things.