Don't send banner display stats event to Doofinder search service

Question

Don't send banner display stats event to Doofinder search service

Closed this issue 3 years ago · 5 comments

The event is automatically counted in the search service (it actually knows it's sending a banner id so it can count the event itself).

Click event must be sent as is now.

Answer 1 · 2020-09-21T11:15:11.000Z

@carlosescri Does it also refer to the module on Magento 2?

Answer 2 · 2020-09-21T12:06:48.000Z

@magently I've created an issue for that. Thanks.

Answer 3 · 2020-09-21T14:27:40.000Z

@carlosescri Changes for M1 are here: https://github.com/magently/doofinder-magento/tree/feature/banners-click

Answer 4 · 2020-09-22T12:15:40.000Z

@carlosescri sorry, we made a mistake in commit msg (instead of register display we wrote register click). Could you please correct it when you make a pull request?

Answer 5 · 2020-09-22T12:41:34.000Z

It's fixed, don't worry: #129

…

--- Carlos Escribano Rey Software Engineer Doofinder <https://www.doofinder.com> El mar., 22 sept. 2020 a las 14:15, magently (<notifications@github.com>) escribió:

@carlosescri <https://github.com/carlosescri> sorry, we made a mistake in commit msg (instead of register display we wrote register click). Could you please correct it when you make a pull request? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#128 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADVWG54FAYFC2PBGEPSJRDSHCIPXANCNFSM4RRXHIVA> .