Fringe does not match the background
Closed this issue · 11 comments
What happened?
The following themes have wrong fringe color that doesn't match background of the window with solaire mode:
doom-1337doom-dark+doom-ephemeraldoom-materialdoom-moonlightdoom-palenightdoom-sourcererdoom-zenburn
Installed commit of doom-themes: 3ab4af2
doom-material and doom-palenight can be removed from that list. Their fringe match.
As for the others, I noticed this but assumed that this was intentional.
cc
- @ccmywish (doom-1337, #545) (verdict: should be changed)
- @ema2159 (doom-dark+, b0c2550)
- @karetsu (doom-ephemeral, 9abda00)
- @Brettm12345 (doom-moonlight, 741defe)
- @fm0xb (doom-sourcerer, #215)
- @jsoa (doom-zenburn, #447)
Can you guys confirm? Your themes give fringe an explicit background color that doesn't match default's :background (for example, screenshots below). Was that intentional? Should it be changed?
As a side-note, users can customize this with:
;; use this after the theme has loaded
(custom-set-faces
`(fringe ((t (:background nil))))) ; make fringe match the bg
doom-materialanddoom-palenightcan be removed from that list. Their fringe match.
on my machine they dont:
doom-material: 
- unreal buffer on the left, fringe, real buffer on the right.
doom-palenight: 
- fringes are in between two real buffers.
Zoom in, it's a bit hard to see, but it's there.
1337-theme should be changed to default bg. Could you help me change it?
The theme was forked from another theme, so I didn't notice this before, I'm sorry. Thanks for your carefulness.
on my machine they dont:
Zoom in, it's a bit hard to see, but it's there.
@andreyorst Ah, that's the window border (represented by the vertical-border face), not the fringe. They're 1px wide, sit between every split, and don't (shouldn't) match the background in any of our themes.
An example of the fringe mismatch I'm looking at:
This is doom-moonlight. The black window border in the middle is padded by ~4px of fringe on both sides that don't match the background color in "real" buffers.
By comparison, doom-material looks correct:
@andreyorst Ah, that's the window border
No, it is not. The window border is visible on my screenshot as well, on the second one in particular. However I've updated today and the issue with these two themes gone. So I assume it was something else. Other themes still don't match.
@hlissner by the way, is it possible for minibuffer to automatically color fringes to the solaire-minibuffer-face color? Rightnow I have to either disable fringes in the minibuffer, or to color it to solaire-default-face. This may be because I'm using mini-modeline package though. IIRC solaire mode did that before the last update, but not for all themes.
@andreyorst It can, but whether or not it's necessary depends on what version of Emacs you're using (and what commit of solaire-mode; it's undergone many big changes in the past week, and will see a few more big changes in the coming week). Could you create an issue in the solaire-mode repo for that?
sure
Has it always been like this? Now I am not sure or maybe I didn't notice it. I've been using Ephemeral almost every day for more than a year and haven't noticed that until now. In my opinion, all of these should be changed. This issue is specially noticeable when using git gutter:
