doorkeeper-gem/doorkeeper-openid_connect

Overriding AuthorizationsController in Development Mode

zacheryph opened this issue · 2 comments

zacheryph commented

We are experiencing an issue in development mode where AuthorizationsController is losing touch with its ancestory. It seems to be due this gem overriding the class directly instead of mixing into and/or not defining a super class. making any changes in development requires reloading the entire application. You can replicate this by doing rails new, adding doorkeeper and this gem, doing doorkeeper:install and then doing the below in console.

This causes issues with NoMethodError binary_params_for? not being defined during requests.

Doorkeeper::AuthorizationsController.superclass
#=> Doorkeeper::ApplicationController
reload!
# Reloading...
#=> true
Doorkeeper::AuthorizationsController.superclass
#=> Object
nbulaj commented

Hi @zacheryph . #173 should fix the issue so you can try it from the branch (for now) or with a release later and report any issues found. Thanks!

  • 👍3
nbulaj commented

Released in 1.8.2

  • 👍3