docker commit should not drop configuration
mhennings opened this issue · 22 comments
Currently when doing a commit on a container to update an image, the configuration the image had is not kept.
I think there should be an option to drop the previous config and a default to keep it.
What configuration are you thinking of?
E.g. dns? mounted volumes?
i had volumes and the cmd in mind.
👍 this hit me hard today :-/ Built up quite a huge Dockerfile with lots of ports EXPOSEd. If I do some work in the container and want to commit as a new image, all ports and also CMD is lost.
+1
On Fri, Sep 13, 2013 at 9:55 AM, asbjornenge notifications@github.comwrote:
[image: 👍] this hit me hard today :-/ Built up quite a huge Dockerfile
with lots of ports EXPOSEd. If I do some work in the container and want to
commit as a new image, all ports and also CMD is lost.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1141#issuecomment-24408559
.
@jpetazzo https://twitter.com/jpetazzo
Latest blog post: http://blog.docker.io/2013/09/docker-joyent-openvpn-bliss/
This was a big one for me today as well!
A friendly tip (might be obvious to most):
As a workaround I just keep a separate Dockerfile with only the configuration stuff that is lost, and the image I'm committing to as FROM. It's not awesome, but it works.
Haha! A dirty hack, but I will use it 'til we see this closed!
Thanks. :)
+1
+1
+1
+1
In addition, docker history imagename should show the configuration overrides that were passed via the -run option to docker commit. So you can see the run configuration.
I know you can do docker inspect imagename but that's all the configuration, not just the overrides from the command line. It's hard to see what the deltas are.
+1 on preserving cmd, ports, env, etc.
I believe this has been fixed, @creack @crosbymichael @vieux can you confirm?
No this is still and issue with docker commit. It was been fixed with docker build but still an issue with commit.
Tagging as easy fix
Any progress on this? Got bit by this today on 0.7.6.
I'm working on this issue, and it is indeed mostly an easy fix. But the wrinkle I've run into is figuring out when the user has specified a new config via commit's -run option. Hopefully there's an easy solution for someone who's been using Go for more than a few minutes.
Here's my progress so far: https://github.com/cap10morgan/docker/compare/fix-issue-1141
The if false is where I need to figure out a way to tell if the user submitted a new config (and then do we merge or replace?).
I've tried comparing the Config struct to an empty one (Config{}), but that doesn't work because there are slice members and they don't support equality comparison.
I've also tried checking for no incoming config JSON, but something in the command -> API -> server cycle is putting an empty struct's JSON representation in there anyway, so that's stuck at the same place.
So does anyone have any tips for a robust way of detecting when the user has submitted a new config on the commit command line?
OR
Should I just work on a shallow merge function that leaves the original container's config values there when there is no value in the request's config but otherwise clobbers it with the request's config values? This would be more work, I think, but if it's the right thing to do (and it seems like it is), then it would obviate the need to detect whether someone had given any config values via the -run option (since they'll all be empty and thus won't override the original container's config).
Update: I just found CompareConfig and MergeConfig in utils.go. I'll just use MergeConfig.
Pull request here: #3889
+1
I closed that PR so I could submit a new one that follows the Docker contrib guidelines a bit better and adds a test. However, I'm a bit stuck on the best way to test that the merged config is correct: cap10morgan@2cf4727
Any tips would be most welcome.
+1