dotnet/TorchSharp

Calls to NativeLibrary should not assume explicit paths

glopesdev opened this issue · 0 comments

glopesdev commented

It seems extremely error-prone to presume to replace the OS-specific library search strategies. It doesn't feel like library developers should assume they have to rewrite how native libraries are found in the system. Application developers should worry about their specific deployments if this doesn't work for them.

This line:

TorchSharp/src/TorchSharp/Torch.cs

Line 60 in 3d01e74

ok = NativeLibrary.TryLoad(path, out var res);

should really just use the full TryLoad overload.