dotnet/aspnetcore

Allow setting `EndpointNameMetadata` for minimal APIs via a first-class extension method

DamianEdwards opened this issue · 1 comments

Endpoint names are used to lookup endpoints when generating links using LinkGenerator, and as their unique per application are a good candidate for using as the operationId for an endpoint in OpenAPI (Swagger) documents.

(domaindrivendev/Swashbuckle.AspNetCore#2165 is tracking setting the operationId from endpoint name by default in Swashbuckle.)

Endpoint names are set using the Microsoft.AspNetCore.Routing.IEndpointNameMetadata interface. In the framework today this can be set imperatively by adding an instance of Microsoft.AspNetCore.Routing.EndpointNameMetadata to the endpoint's metadata, e.g. builder.WithMetadata(new EndpointNameMetadata("GetTodoById")).

We should add a new extenstion method to allow setting the endpoint name in a more first-class fashion:

using System;
using Microsoft.AspNetCore.Http.Extensions;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Routing;

namespace Microsoft.AspNetCore.Builder;

public static class RoutingEndpointConventionBuilderExtensions
{
+     /// <summary>
+     /// Adds an <see cref="EndpointNameMetadata"/> item to the <see cref="IEndpointConventionBuilder"/> for all endpoints produced by the builder.
+     /// </summary>
+     /// <remarks>
+     /// Endpoint names must be unique within an application, and can be used to unambiguously
+     /// identify a desired endpoint for URI generation using Microsoft.AspNetCore.Routing.LinkGenerator.
+     /// </remarks>
+     /// <param name="builder">The <see cref="IEndpointConventionBuilder"/>.</param>
+     /// <param name="name">The endpoint name.</param>
+     /// <returns>The <see cref="IEndpointConventionBuilder"/>.</returns>
+     public static TBuilder WithName<TBuilder>(this TBuilder  builder, string name) where TBuilder : IEndpointConventionBuilder
+     {
+         builder.WithMetadata(new EndpointNameMetadata(name));
+ 
+         return builder;
+     }
}

The extension method could be used in the following way:

app.MapGet("/todos/{id}", async (int id, TodoDb db) =>
    {
        return await db.Todos.FindAsync(id)
            is Todo todo
                ? Results.Ok(todo)
                : Results.NotFound();
    })
+   .WithName("GetTodoById");

app.MapPost("/todos", async (Todo todo, TodoDb db) =>
    {
        db.Todos.Add(todo);
        await db.SaveChangesAsync();

        return Results.CreatedAtRoute("GetTodoById", new { todo.Id }, todo);
    })
+   .WithName("AddTodo");

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.