WebHostOptions default ShutdownTimeout does not match HostOptions default ShutdownTimeout
hwoodiwiss opened this issue · 5 comments
Describe the bug
The default value for ShutdownTimeout in Microsoft.Extensions.Hosting.HostOptions was updated to 30 seconds as part of dotnet/runtime#63709
The default value for ShutdownTimeout in WebHostOptions should be made consistent with this so that the default shutdown behaviour is consistent for services using GenericWebHostService and WebHost.
Expected Behavior
Default values for HostOptions.ShutdownTimeout and WebHostOptions.ShutdownTimeout should match for consistent stopping behaviour across both when ShutdownTimeout has not been set via configuration (Config for key: shutdownTimeoutSeconds)
Steps To Reproduce
No response
Exceptions (if any)
No response
.NET Version
No response
Anything else?
No response
@ReubenBond Does it make sense to propagate this change? I like consistency, but I'd like to confirm there isn't a reason to keep them independent.
Yes, it makes sense. They should all have the same default values
Sounds like we're on board with the suggestion. @hwoodiwiss, would you like to submit a PR for this?
I've got a PR open for this here #48606
🤦 So you do