[Question] Why double check IsRepeatOver in SpanShouldKeepJobRunning?
catcherwong opened this issue · 2 comments
catcherwong commented
I found that IsRepeatOver was called twice while debugging, but it seems that the results of both calls are the same. Is it enough to keep only one call here?
crank/src/Microsoft.Crank.Controller/Program.cs
Lines 1272 to 1275 in 158a5e4
sebastienros commented
I think that's a mistake, correct.
catcherwong commented
Ok, I submit a PR #572 for it.