dotnet/crank

[Question] Why double check IsRepeatOver in SpanShouldKeepJobRunning?

catcherwong opened this issue · 2 comments

I found that IsRepeatOver was called twice while debugging, but it seems that the results of both calls are the same. Is it enough to keep only one call here?

if (IsRepeatOver() || IsRepeatOver())
{
return false;
}

I think that's a mistake, correct.

Ok, I submit a PR #572 for it.