Need to remove RazorCompiler dependency when upgrading to Roslyn 4.10.0
mthalman opened this issue · 2 comments
Roslyn deleted the Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler package in dotnet/roslyn#71579. But format still has references to it that need to be removed:
format/Directory.Packages.props
Line 40 in 2036958
format/src/dotnet-format.csproj
Line 39 in 2036958
This currently isn't broken because format still has a dependency on Roslyn 4.9.0; the deletion is in 4.10.0
This seems like an automatic maintenance task that will occur during a dependency update. Is there a reason why we need to track it separately? It seems like even once this issue is fixed, it will likely remain open as the author of the pull request to update dependencies wouldn't be aware of its existence.
This was logged because it required a patch in the installer repo to get source build working since it uses the latest version of Roslyn in source build. When creating a patch, we need to reference an existing issue or PR to track the work so that it ensures the underlying issue gets resolved. Anyway, this has been fixed and the patch was removed in dotnet/installer#18641. Closing.