Reenable some SDK tests for the internal PR builds
marcpopMSFT opened this issue · 7 comments
When we go internal, we target the unreleased runtimes so a bunch of tests have to be disabled. We should investigate whether we can reenable those for the servicing codeflow that should have access to those runtimes.
CC @mmitche you mentioned there was a good way to tell when it was an internal PR build versus a public one?
@marcpopMSFT Which project the pipeline is running in. E.g. https://github.com/dotnet/arcade/blob/main/azure-pipelines.yml#L63
So basically I should have a second test config file and base it off of whether it's public versus internal? Seems feasible. I'll play around with that for the 8.0.1xx branch.
@mmitche Digging into this, we pick the testconfig xml within this csproj file: https://github.com/dotnet/installer/blob/main/test/SdkTests/SdkTests.csproj#L211
The variables you pointed me at in the yml aren't available in msbuild. I could potentially set a value as an environment variable to pass it through but that seems clunky. Can't find an alternative msbuild property that indicates whether I'm building in dnceng or dnceng-public
I would do what we do with the internal runtime download arguments. If under internal in the YAML, pass an additional parameter (e.g. InternalBranchTesting=true) to the msbuild command. Then that alters behavior.