dotnet/interactive

Polyglot Notebook: [NetTestingE2E][Loc] Error strings "Error: Command cancelled." and "Error: Value 'undefinedVariableName' not found ..." are not translated.

Opened this issue · 0 comments

REGRESSION: No regression info since it's our first time to try Loc test on this.

Describe the bug
The strings of error message are not translated after executing the cell.

Error: Command cancelled.
Error: Value 'undefinedVariableName' not found in kernel pwsh

Note:

  1. Repro VM: 10.158.80.11.

Pre-steps:
1.On ENU OS, install VSCode and dotnet-interactive-vscode-1.0.6323011.vsix extension componet.
2. Install the language package of Japanese from VSCode -> Change the display language of VSCode to Japanese

Steps:

  1. Ctrl+Shift+P => "Polyglot Notebook: Create new blank notebook"
  2. Select "Create as .dib" ->Select "C#" -> Specify the code in cell-> Add the following code
    using System.Threading.Tasks;
    using Microsoft.DotNet.Interactive;
    var output = string.Empty.Display("text/plain");
    var counter = 1;
    while (!KernelInvocationContext.Current.CancellationToken.IsCancellationRequested)
    {
    await Task.Delay(500, KernelInvocationContext.Current.CancellationToken);
    output.Update($"{counter++}");
    }
  3. Execute the cell
  4. Stop cell execution and observe the output
  5. From step2, add the code
    #!share --from pwsh undefinedVariableName
    1+1
  6. Execute the cell and observe the output

Build info:
Detailed Repro Build info: VSCodeUserSetup-x64-1.101.2 +dotnet-interactive-vscode-1.0.6323011.vsix
VSCode Link: https://code.visualstudio.com/insiders/#
dotnet-interactive-vscode-1.0.6323011.vsix
https://dev.azure.com/dnceng/internal/_build/results?buildId=2177104&view=artifacts&pathAsName=false&type=publishedArtifacts
Sdk info: dotnet-sdk-9.0.300-win-x64.exe

Actual Results:
Step 4: String "Error: Command cancelled." is not translated.
Image
Step 6: String of "Error: Value 'undefinedVariableName' not found in kernel pwsh" is not translated.
Image

Expected Results:
Step 4 & 6: All strings of the output should be translated.
Please complete the following:

Which version of .NET Interactive are you using?** (In a notebook, run the #!about magic command. ):

  • OS
    • [√ ] Windows 11
    • Windows 10
    • macOS
    • Linux (Please specify distro)
    • iOS
    • Android
  • Browser
    • Chrome
    • Edge
    • Firefox
    • Safari
  • Frontend
    • Jupyter Notebook
    • Jupyter Lab
    • nteract
    • [ √] Visual Studio Code
    • Visual Studio Code Insiders
    • Visual Studio
    • Other (please specify)