FlyoutPage.IsPresented behaves different to Xamarin 5
jbe2277 opened this issue · 1 comments
Description
The documentation shows that IsPresented
must be set to false
so that the flyout closes on phones:
void OnSelectionChanged(object sender, SelectionChangedEventArgs e)
{
var item = e.CurrentSelection.FirstOrDefault() as FlyoutPageItem;
if (item != null)
{
Detail = new NavigationPage((Page)Activator.CreateInstance(item.TargetType));
IsPresented = false;
}
}
But this code throws an exception on the Windows platform:
maui/src/Controls/src/Core/FlyoutPage.cs
Lines 286 to 289 in 65104a2
Please, update the documentation. See workaround.
Xamarin: The behavior changed since Xamarin 5. In Xamarin I have used:
https://github.com/jbe2277/waf/blob/acbf97f70736203b47e5e99d399d691d6121fb0f/src/NewsReader/NewsReader.Presentation/Views/ShellView.xaml.cs#L64
This doesn't work correct anymore. The exception is raised on the Windows platform.
Maybe related: #9801
Steps to Reproduce
Clone this repo:
https://github.com/jbe2277/waf/tree/b42f0f1a26287dce428f3c34a2c90b4a7d2aeab7
Link to public reproduction project repository
https://github.com/jbe2277/waf/tree/b42f0f1a26287dce428f3c34a2c90b4a7d2aeab7
Version with bug
6.0.486 (current)
Last version that worked well
Unknown/Other
Affected platforms
Windows
Affected platform versions
net6.0-windows10.0.19041.0
Did you find any workaround?
This commit solved the issue:
jbe2277/waf@69803ce
The important part is:
if (!((IFlyoutPageController)this).ShouldShowSplitMode) IsPresented = false;
I believe this API has some flaws:
- It's necessary to cast
this
so thatShouldShowSplitMode
can be accessed. However, this is a main use case and so it should be accessible directly viaFlyoutPage
. - The
CanChangeIsPresented
property which I used first for the check doesn't work as expected. Although the property returnedtrue
, setting ofIsPresented = false
resulted in the exception.
Relevant log output
No response
Verified this issue with Visual Studio Enterprise 17.8.0 Preview 1.0. Can repro on windows platform with sample project.
waf.zip