dotnet/msbuild

Some projects are not associated with the MSBuild task that caused them to build

Closed this issue · 6 comments

KirillOsenkov commented

In 16.6.1 I'm seeing a situation where projects are not parented under the MSBuild task that spawned them.

image

Repro:

  1. git clone https://github.com/xunit/xunit
  2. git checkout 2.4.1
  3. cd xunit\src\xunit.runner.utility
  4. msbuild /r /bl

#5013 has implemented that we pass the parent task ID to ProjectStarted.ParentProjectBuildEventArgs, but I'm seeing parent task id == -1.

This only happens for some projects; most projects work fine.

KirillOsenkov commented

Apparently others have also run into the same build error here: xunit/xunit#1972

KirillOsenkov commented

xunit/xunit#1819 is related as well.

KirillOsenkov commented

OK I think I found the real root cause of the build issue: novotnyllc/MSBuildSdkExtras#127

KirillOsenkov commented

I have a suspicion that this could happen in the "previously built successfully" situation.

KirillOsenkov commented

This was much easier than expected. I just missed a case.

  • 🚀1