dotnet/project-system

Disallow editing contentfiles from packages

Closed this issue · 7 comments

srivatsn commented

Content files from nuget package simply show up in the tree as editable items. #604 tracks coming up with a proper editing experience by cloning the file but until then we should just mark them as readonly so that users don't accidentally change the packages.

bording commented

Is there any chance of this being addressed in the VS 2019 timeframe? This is a problem that should definitely be fixed!

drewnoakes commented

When addressing this, see if we can get invocation to open content file items in the dependencies tree to open the file, also non-editable.

Barsonax commented

Any chance this is gonna get fixed soon? This seems to be a pretty serious bug as it makes it possible to edit a shared package.

According to the documentation contenfiles should be readonly so tooling should respect that!

  • 👍1
jjmew commented

@ocallesp This is came up because #6290 we believe this is important as we shouldn't allow those files to be edited.

ocallesp commented

@drewnoakes I created a simple Console NetCore project and added the nuget package AdamsLair.Duality.Samples.Tilemaps. There are some files under Content Files, but cannot open or edit them.
Was editing already disabled ? It seems that this issue was fixed, but should be able to open the res files ?

image

drewnoakes commented

@ocallesp these nodes were never wired up for interaction beyond the browse object. We may do that in future.

This bug relates to the equivalent items within the "Data" folder at the bottom of your screenshot.