Follow up feedback with logging source generator
maryamariyan opened this issue · 2 comments
maryamariyan commented
Using this issue to keep track of issues to fix based on initial feedback with using source generator:
LoggerMessageAttribute:
- #52222 Move Logging Source Generator to MS.Extensions.Logging.Abstractions
- #51965 Logging generator - for enumerable input argument, add missing helper method
- #51917 Logging-Generator doesn't use LoggerMessage.Define for > 1 template argument
- #52221 LoggerMessage - SYSLIB1008 should have a better message
- #52277 Logging Source Generator fails with a NullReferenceException
- #52276 LoggerMessageAttribute should have a constructor that takes EventId, LogLevel, and Message
- #52301 Support nested logging classes in Logging Source Generator
- #52223 LoggerMessage - Allow Event ID to be optional
- #51927 Logging-Generator should allow to skip the IsEnabled check
- #54008 Logging Generator: messaging fix
Post 6.0 work:
Post-release feedback:
- #61162
- #64310
- #62644 - Logging Source Generator fails to compile when in parameter modifier is present
- #60968 - Logging Source Generator fails to compile using keyword parameters with @ prefixes
- #61814 - Logging Source Generator fails ungracefully with overloaded methods
- #58550 - Logging Source Generator fails to compile due to CS0246 and CS0265 errors if type for generic constraint is in a different namespace
- #56203
In .NET 8.0 timeframe
dotnet-issue-labeler commented
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.
Deleted user commented
Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.
Issue Details
Using this issue to keep track of issues to fix based on initial feedback with using source generator:
LoggerMessageAttribute:
LoggerMessage.Define:
| Author: | maryamariyan |
|---|---|
| Assignees: | - |
| Labels: |
|
| Milestone: | - |