[9.0.1.xx-rc1] SDL Analysis Fails to Checkout VMR
ellahathaway opened this issue · 9 comments
Checkout dotnet-dotnet@release/9.0.1xx-rc1 fails in 9.0.1xx-rc1 builds with the following error:
fatal: No url found for submodule path 'src/wpf/origin/wpf' in .gitmodules
##[error]Git submodule update failed with exit code: 128Checkout succeeds in other stages, it's only the SDL Analysis stage that encounters this error.
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.
This is a result of the submodule being added in this PR: dotnet/wpf#9601
@singhashish-wpf - can you please take a look? TIA
cc @premun - Submodules get flattened out in the VMR so I wouldn't expect an issue. Is there something special going on here?
They do.. It's weird, though, there's no .gitmodules file in the repo so I have no idea how is there a submodule even in the first place
Okay, so it seems like wpf has a broken submodule. The submodule was added, so the git tree has the COMMIT item inside but the .gitmodule file has not been added into git so there's no information where to get the submodule from.
Even trying to initialize it locally in the original repo does not work:
D:\repos\wpf> git submodule init
fatal: No url found for submodule path 'origin/wpf' in .gitmodules
@singhashish-wpf or @dotnet/dotnet-wpf - friendly ping :) Do you know why this submodule was adding in dotnet/wpf#9601? It's breaking our builds.
@singhashish-wpf or @dotnet/dotnet-wpf - friendly ping :) Do you know why this submodule was adding in dotnet/wpf#9601? It's breaking our builds.
This got added by mistake. Deleted.
This will be fixed once dotnet/sdk#42997 is merged.