dotpcap/packetnet

log4net dependency in nuget package

wo80 opened this issue · 3 comments

wo80 commented

Hi.
The latest nuget packages (1.4.5, 1.4.6-pre) have a dependency on log4net. Is this intended? Looking at the PacketDotNet.csproj project file, it seems a debug version was published by accident...

PhyxionNL commented

I see, that's odd. It should build the release version:
https://github.com/dotpcap/packetnet/blob/master/.github/workflows/master.yml#L70

I've pushed a commit that hopefully addresses it :)

PhyxionNL commented

It was because dotnet test was building the debug version, which caused a debug NuGet package to be generated as well. This'll be fixed in #183.

  • 👍1
wo80 commented

Thanks for the quick 1.4.6 release!

  • 👍1