[FEATURE] Make Deprecation warning on AppStoreValidator conditional
M-R-Epstein opened this issue · 0 comments
M-R-Epstein commented
Detailed Description
The AppStoreValidator __init__ method is emitting a deprecation warning in all cases currently.
Context
The deprecation warning is creating additional noise in test results for any project using AppStoreValidator even if the deprecated argument is not being used.
It's also triggering deprecated class warnings in my IDE.
Possible Implementation
if bundle_id:
warnings.warn("bundle_id will be removed in version 3, since it's not used here.",
PendingDeprecationWarning)Happy to make a PR for this if it isn't objectionable but the PR template requests that an issue be created/discussed.
Your Environment
- Version used: 2.5