dougmencken/HeadOverHeels

GameManager looks too oversized, how about splitting it

dougmencken opened this issue ยท 3 comments

... and maybe it even smokes ๐Ÿ˜‰

these look suspicious

void fillWithData ( const GameManager & data ) ;

void PlayerItem::fillWithData( const GameManager & data )

GameManager as an argument, to copy the character-related data, and it's inside PlayerItem, hmmm ..... ๐Ÿค”

it is also possible that this manager sometimes plays solitaire instead of managing

doesn't this

unsigned short howManyDoughnuts ;

unsigned short getDoughnuts () const { return this->howManyDoughnuts ; }

duplicate that

unsigned short getDonuts ( const std::string& player ) const ;

unsigned short donuts ;

and so on ?

well, now it looks okay

* Manages the game, and nothing more. Doesn't play solitaire. Doesn't smoke. Anything at all. Really.