Adding last_login to FAB for Superset
sfirke opened this issue · 1 comments
sfirke commented
I'd like to implement apache/superset#22185 (comment), adding a last-logged-in field to Apache Superset. As far as I can tell, Superset imports UserModelView
from FAB and uses it as-is. So if this modification to the default could happen in FAB, it would involve a tiny change, but if Superset broke from FAB here it would involve copying a lot of FAB code that would then be harder to maintain.
Is that correct? If so, are you open to adding last_login as a default displayed field in FAB? And is that addition as simple as I've laid out in my linked comment above?
Thanks for considering!
dpgaspar commented
Could be a nice addition as long as it fits well on the table, feel free to open a PR.