get_string('post') for the submit button does not work in each language
lucaboesch opened this issue · 4 comments
Thanks for your great Plugin!
I want to notice you that the core 'post' string does not fit in each language.
You see, 'post' can mean two things:
The 'post' as the noun. It's the post itself.
And then there's 'post' the verb. I'm about to post a question.
Core 'post' is the noun.
In some languages the verb and the noun differ.
I'd kindly advise you to take into consideration a propietary get_string('post', 'mod_hotquestion') string which would contain the verb. Even if in english, that is a homonym.
Thanks for spotting that missing language string. I have fixed a number of missing strings since I took over support for Hot Question, but did not see this one. If you spot any others, please let me know. I will try to get a fix out soon. Right now, we are waiting for hurricane Michael to hit, sometime within the next 15 hours. I live only about 80 miles north of the expected landfall point of Panama City, Florida. Already had a couple of electric power glitches, so it might be a while to get this completed.
Keep safe, Al!
I wish you all the best.
Luca
Got lucky with the storm. The eye of the hurricane passed about 50 miles to the southeast so we just had lots of wind and rain. Our only damage is a yard full of small twigs and lots of leaves.
Took me a while to find where the language string for the "Post" button is being applied as it is not in the logical place for it, and I have not taken the time to move it since I took over responsibility for the plug in. It can be changed and customized just like any other language string. It is "Post" in core moodle.php but I will see about adding a specific Hot Question language string in the next release.
Code changed in mod_form.php to use new language string.