Hot Question 4.1.7 - The defaults of the approval mechanism
acquaalta opened this issue · 5 comments
Hi,
Moodle version: 4.1.3
Hot Question version: 4.1.7
It seems that even when the setting "Approval required" in the activity settings page is set to "No", the "Unapproved question visibility" dropdown/mechanism is set to "Preference not set", leading to that the questions/subjects are not presented in the list. To the user/teacher that doesn't notice it, it seems like something is wrong and the question/subject is not added to the activity.
Please note that the "Unapproved question visibility" setting is not even exposed in the site administration settings of the plugin, so the admin can't even change the default so users would be less confused.
Could you please change the default of this setting (so it would show all the question/subjects, even if they are unapproved yet) or expose this setting in the site administration?
BTW, because of the that, I'm not upgrading to v4.1.7, and stay with v4.1.6, so I hope there isn't something in the new v4.1.7 that makes it a must upgrade.
Thanks :-)
It seems that even when the setting "Approval required" in the activity settings page is set to "No", the "Unapproved question visibility" dropdown/mechanism is set to "Preference not set", leading to that the questions/subjects are not presented in the list.
-- That's because they are two, totally different things. "unapproved question visibility" is an individual preference. i.e. Do I want to clutter up my listing with these unapproved questions that I possibly cannot read anyway. It has to be set at least once for the listing to know how to handle them.
Please note that the "Unapproved question visibility" setting is not even exposed in the site administration settings of the plugin, so the admin can't even change the default so users would be less confused. -- That's because it is NOT a setting. It is just a preference that I can change for every different Hot Question activity. Moodle will remember the preference for everyone and for every Hot Question activity.
Could you please change the default of this setting (so it would show all the question/subjects, even if they are unapproved yet) or expose this setting in the site administration? -- Again, it is not a setting. It is an individual preference for each user in each Hot Question activity. However, in the next release, I will have it so the list does get populated, but it is still going to confuse some people because they will see the questions, but the setting will show that their preference is still, "Preference not set."
BTW, because of the that, I'm not upgrading to v4.1.7, and stay with v4.1.6, so I hope there isn't something in the new v4.1.7 that makes it a must upgrade. -- No, there is no, "must upgrade" content in the v4.1.7 release. You can always go look in the upgrade.txt file to see what is in a release. I try to make sure that file is always up to date with what I've done each day and will be in the release. But, because I maintain four plugins by myself, with three of them always undergoing significant upgrades to what they can do, I sometimes do forget to upgrade that file on time. The past four years have really been trying for me due to multiple deaths of family members due to COVID, heart failure, and cancer, and the recent passing of my dog. In fact I am waiting to receive her ashes so I can place them with my wife's, her owner.
Just pushed the changes to the master branch where you can try the change. I will take another day or two for more testing to make sure things are working as expected.
_The past four years have really been trying for me due to multiple deaths of family members due to COVID, heart failure, and cancer, and the recent passing of my dog. In fact I am waiting to receive her ashes so I can place them with my wife's, her owner.
- The "Hot Question" plugin is great, IMO.
- But what's more important for me is what you wrote in the last paragraph. I want to send you a big big hug, and of course my condolences. Even one family death is devastating and heart-braking, so multiple deaths is something that is hard to grasp. And I assume that for you your dog was also another family member.
I want to believe that all of them enjoyed your time with you, and that's something that you need to be happy about.
Remember to "fill your battery" with rest or meeting people or watching some stuff or hiking or other things that would do you good. The plugins can wait with improvements... You (the developer) are the most important plugin ❤️
Thanks for the kind words.
I just pushed my latest changes to the master branch for HQ v4.1.7+. So far I've only had time to test on Moodle 4.2. Will try to test down to Moodle 3.11 tomorrow, but I also have pressing issues on MooTyper and Diary that I need to look at, also, so it might be a couple of days before I get far enough along to release an actual new version.
20230612 The fix for this was included in yesterday's release of Hot Question v4.1.7.02+.