race while reading from channel variables
Opened this issue · 1 comments
Hello,
We are using mod_google_transcribe for ASR. We observed race in setting the required channel variables for GSR & invoking the uuid_google_transcribe command. Worth mentioning, we are using a go client to send commands using mod_event_socket. What we ended up doing was modify the existing API & pass all the variables in the command. Setting sample rate is also dynamic which fixes #48.
If this is something which you would want, we can create a PR with modified API or a new API (say uuid_google_transcribe2), so as to not break existing applications. Please let us know. Thanks.
FYI @Chetan177
yes it is expected that you would wait for the 'set' application to return before you call uuid_google_transcribe.
As far as providing all variables on command line, I would be interested to see a PR but I would need to work out a way to make it backwards compatible, which I would think should be possible.
So yes, would be interested in seeing a PR with your changes