dracula/gitk

Error when trying to resize

gkotian opened this issue · 8 comments

gkotian commented

When I try to drag the horizontal bar in the middle to resize the top/bottom panes, I get the following error:

expected integer but got ""
expected integer but got ""
    while executing
"$win sash place 0 $sash0 [lindex $s0 1]"
    (procedure "resizeclistpanes" line 38)
    invoked from within
"resizeclistpanes .tf.histframe.pwclist 1903"
    (command bound to event)

I'm using Arch Linux, and my git version is 2.30.1.
Any idea how to fix this?

Here's a screenshot:
screenshot

fedorenchik commented

I have the same error. (I'm on Manjaro)

smith-j-travis commented

Changing

set want_ttk 0
to
set want_ttk 1

seems to have fixed the issue for me

  • 👍1
gkotian commented

Yes, using set want_ttk 1 allows for resizing the top & bottom panes, but badly messes up the look of the theme 😞

Here are some screenshots for comparison.

With set want_ttk 0:
want_ttk_0

With set want_ttk 1:
want_ttk_1

  • 👍2
mdelapenya commented

Setting want_ttk 0 fixed the issue to me

  • 👍1
suratovvlad commented

I have the same issue with Fedora 34

senhalil commented

I think I have a fix for this issue (at least on local with the fix my gitk doesn't return expected integer but got "" during resize).

I opened the following pull-request 🤞 hopefully this annoyance will soon be over.

If anyone here is a gitgitgadget/ user and "allow" my PR, it would be awesome.

  • ❤️2
gkotian commented

Thanks @senhalil for the fix. I confirmed that it works, and also left a comment on the PR. No idea what's holding it up though.

  • 👍2
gkotian commented

Closing as git/git#1219 has been accepted. The world will soon have an awesome gitk again! 🎉

  • 😄1
  • 🎉1