dracula/notepad-plus-plus

Command/String highlighting broken(?)

leo-liar opened this issue · 9 comments

leo-liar commented

Hello there,

one of the last 2 commits (352c9f9 and/or 8b274bc) has broken text/command highlighting – the coloring scheme either fails to recognize commands correctly and colors them as text or the changes within these commits made the coloring of commands (as compared to strings) worse. I've observed this at least with batch and python files. Please see the following screenshots.

  • most recent Dracula.xml:

    python fileimage
    batch fileimage

  • previous Dracula.xml

    python fileimage
    batch fileimage

  • standard theme

    python fileimage
    batch fileimage

See also for comparison the screenshot at the beginning of README.md!

leo-liar commented

Another bug I just recognized:
The recent Dracula.xml changed the line highlighting color (made it a bit brighter) but now text selections aren't visible anymore – the active line highlight is the same color as selected (e.g. as in CTRL + A) text.

  • 👍2
ghesio commented

Hello everybody,

i'm noticing the same issue as reported in the comment above: highlight in some cases disappears, but I haven't be able to consistently reproduce it.

hnavia commented

I confirm this. I can't see the selection highlighted

maxxber commented

Hello, I have the highlighting problem too:

it seems I'm able to see the selection of a single word with double left click of mouse; if I want a more precise selection, for example dragging the mouse from a certain letter in the middle of the word, there is no highlight.

It's quite confusing in the workflow having an issue like this.

maxxber commented

Looking at the xml structure, I found the line number 534, responsible for the highlight function:
<WidgetStyle name="Selected text colour" styleID="0" bgColor="44475A" fgColor="F8F8F2" fontStyle="0" />

Maybe that color choice is conflicting with line 533, responsible for the current line selected color:
<WidgetStyle name="Current line background colour" styleID="0" bgColor="44475A" fgColor="F8F8F2" fontSize="" fontStyle="0" />

I see there are the same bgColor and fgColor exadecimal values!

maxxber commented

Hello, sorry for new post but I found a temporary solution for the highlight problem:

  • navigate to Settings > Style Configurator
  • select Dracula theme
  • select "Selected text colour"
  • click on small square beside "Background color"
  • select a different color
  • select "More Colours..."
  • insert values for red 189, green 147, blue 249 to have a pleasant violet color in theme

Enjoy!
(updated)

  • 👍1
  • 👎1
hnavia commented

Hello, sorry for new post but I found a temporary solution for the highlight problem:

  • navigate to Settings > Style Configurator
  • select Dracula theme
  • select "Current line background"
  • click on small square beside "Background color"
  • select a different color
  • select "More Colours..."
  • insert values for red 189, green 147, blue 249 to have a pleasant violet color in theme

Enjoy!

I would suggest to change the "Selected text colour" instead. That way you can highlight the selection instead the whole string.

Great call!

  • 👍1
maxxber commented

Hello, sorry for new post but I found a temporary solution for the highlight problem:

  • navigate to Settings > Style Configurator
  • select Dracula theme
  • select "Current line background"
  • click on small square beside "Background color"
  • select a different color
  • select "More Colours..."
  • insert values for red 189, green 147, blue 249 to have a pleasant violet color in theme

Enjoy!

I would suggest to change the "Selected text colour" instead. That way you can highlight the selection instead the whole string.

Great call!

I updated my previous post, thanks!!!

Update: I found the correct color to hide "Current line background": red 40, green 42, blue 54.

In this way there is no more current line highlighting and the theme is more polished and balanced!