[Bug Report] Incorrect parsing of launch arguments in PCSX2 shell script

[mykbit]

Prerequisite Steps

• I have searched existing issues
• This issue is not a duplicate of an existing one
• I have checked the EmuDeck Wiki
• I have read the Troubleshooting Page on the EmuDeck Wiki

What distro are you running?

SteamOS

Which SteamOS Branch are you using?

Stable

What happened?

The issue is that PCSX2 shell script within ~/Emulation/tools/launchers/ does not parse launch arguments correctly. Normally, I boot PCSX2 from Steam, so I inserted -bigpicture flag in Steam Launch Options after it was removed from the default configuration of the shell file. However, no matter which flag I insert, the app doesn't boot at all. Directly starting the shell file with ./pcsx2-qt.sh -bigpicture did not help either.

Then I inserted echo "$param" right after param=$(echo "$param" | sed 's/.$/"/'). You can see the output below.

As you can see, current parsing algorithm substitutes the last character with " even though it's supposed to substitute only single quotes.

I have already written a fix for it, which I will upload as a pull request and tie it to this issue shortly.

Relevant log output

https://pastebin.com/LnQemPFf

[mykbit]

I messed up the connection of the pull request and the issue, so here's the link:
#1233

Or you can find the pull request by number 1233

[mjcampagna]

Is this why PCSX2 crashes when trying to run from ES-DE? I'm only able to run it as a standalone app.

[mykbit]

Closing as the fix is already in dev branch.