Remove pervasive shift+enter key shortcut
jjant opened this issue · 5 comments
I spent some time trying to find what was breaking my ability to use shift+enter to do stuff (move to previous result in search, for example). Turns out this extension hijacks this for the inline-repl thing (which doesn't even work for me).
Please remove this or at least add it in the settings.
Oops, I didn't actually realize that implementing a shortcut key worked like that. Sorry about this. I'll see if I can say fall back to other shortcut assignments when there's nothing to do.
Until a fix is ready though, I suppose you can disable shift+enter within the keyboard shortcut settings or move it to a different key. It's pretty customizable after all.
Speaking of inline-repl not working, do you have any specifics? Is this confusing/not running?
Inline REPL: Add REPL blocks to your code with haddock syntax, either using no spaces before
>>>or put it in a comment like-- >>>. Click on the code lens or typeShift+Enterto run a single block, or typeShift+Alt+Enterto run all blocks in a file.
You can open a new issue about that, or just tell me about it here.
I think I found out what happened. I wrote this as the condition for the shortcut key:
editorLangId == haskell && config.ghcSimple.feature.inlineRepl
however, I did not realize that this would still apply if the user is focused on the search bar. A editorTextFocus is needed for the intention of 'user is in editor'.
Also disabling the inline REPL feature in the extension settings should also turn it off. Unchecking this should work:
Does this satisfy what you meant by 'at least add it in the settings'?
I seem to have found a case where the the inline repl randomly doesn't work. I hope I can work on it after my finals.
As it seems that the feature requested is indeed available, and that there has been no more clarification, I'm closing this issue. A possibly related problem with the inline repl 'not working' will be tracked in #85.