drbrain/net-http-digest_auth

rake test aborted on Ruby 1.8.7

kitamomonga opened this issue · 1 comments

"rate test" returns warnings and syntax error on ruby-1.8.7(-p302).

./lib/net/http/digest_auth.rb:114: warning: don't put space before argument parentheses
./lib/net/http/digest_auth.rb:114: warning: useless use of a variable in void context

./lib/net/http/digest_auth.rb:114: syntax error, unexpected ',', expecting kEND (SyntaxError)
request_digest.push ('%08x' % @nonce_count), @cnonce, qop if qop
                                                ^
./lib/net/http/digest_auth.rb:114: syntax error, unexpected kIF_MOD, expecting '='
request_digest.push ('%08x' % @nonce_count), @cnonce, qop if qop
                                                                ^

No errors occur on Ruby 1.9.x, of course.
Please to:
request_digest.push('%08x' % @nonce_count, @cnonce, qop) if qop

seems to be fixed at ca0b75e, and version 1.1.1. thank you!