drewkerrigan/nagios-http-json

Broken Makefile and lint test

Closed this issue · 1 comments

Makefile uses python should be python3
and I got a lint error on Debian Bullseye and Ubuntu Focal Fossa:
python3 -m pylint check_http_json.py
************* Module check_http_json
check_http_json.py:614:0: E0012: Bad option value 'consider-using-with' (bad-option-value)

Regarding the use of python3, we can change that. The script uses #!/usr/bin/env python3 anyways.

About the lint errors. I don't really have an explanation, nor can I recreate the issue.

podman run -ti --rm -v $(pwd):/app --entrypoint bash docker.io/python:3-bullseye                    
root@f49b22a6dcb0:/app# pip3 install -r requirements-dev.txt 
root@f49b22a6dcb0:/app# make lint
python3 -m pylint check_http_json.py

------------------------------------
Your code has been rated at 10.00/10

Same works with bookworm:


podman run -ti --rm -v $(pwd):/app --entrypoint bash docker.io/python:3-bookworm
root@b6471af0a1a5:/app# pip3 install -r requirements-dev.txt 
root@b6471af0a1a5:/app# make lint
python3 -m pylint check_http_json.py

------------------------------------
Your code has been rated at 10.00/10