Implement TgaHeaderReader.TryExtract to not use exceptions as information
drewnoakes opened this issue · 0 comments
drewnoakes commented
The current implementation of TgaHeaderReader.TryExtract
returns false
from a catch
block. It should, instead, use return values to indicate when extraction failed.
This is more relevant than it may seem at first, as the FileTypeDetector
infrastructure uses this code path to detect whether a file is TGA or not (there is no easy way to detect TGA, so we just attempt an extraction). For bulk file processing, this exception can occur regularly. This makes debugging annoying, and can hurt performance.