Core not usable on PS3

Question

Core not usable on PS3

crystalct opened this issue 4 years ago · 8 comments

Beetwen v3.0.4 and v3.1.0 was introduced an issue on PS3 that makes Gearboy non usable.
RPCS3 emulator send an not well identificated sys_memory_allocate' failed.
Further investigation will be required.....

Answer 1 · 2020-12-13T10:53:06.000Z

I don't have the hardware to test this, any help is welcome.
Can you confirm that 3.0.4 works on PS3?
I had some endianness issues in the past, maybe something related.

Answer 2 · 2020-12-13T11:00:04.000Z

With endians modification It works. With a bit of free time, i Will find the problem. Thanks Il dom 13 dic 2020, 11:53 Ignacio Sanchez Gines <notifications@github.com> ha scritto:

…

I don't have the hardware to test this, any help is welcome. Can you confirm that 3.0.4 works on PS3? I had some endianness issues in the past, maybe something related. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#124 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMY7LO6X2P2I4ZRDFBIFVTSUSMJ7ANCNFSM4UZMI7MA> .

Answer 3 · 2020-12-13T18:12:18.000Z

Commit 9b90dce introduced the issue.....
21 files changed... many of these about memory.... let's see.

Answer 4 · 2020-12-13T19:08:32.000Z

Memory.cpp
m_pDisassembledROMMap = new stDisassembleRecord[MAX_ROM_SIZE]; cause:

exception: bad allocation
abort() is called from 0x000000000072cf78
                  from 0x000000000072bfbc
                  from 0x000000000072bed0
                  from 0x000000000049dd9c
                  from 0x0000000000496e04
                  from 0x0000000000494f60
                  from 0x00.........................

It's the same problem as libretro/RetroArch#11537 and libretro/RetroArch#11527
Is it possible save some stack ram using dynamic allocation of memory like this?

#ifdef __CELLOS_LV2__
         char *msg = (char*)malloc(8192 * sizeof(char));
#else
         char msg[8192];
#endif

#ifdef __CELLOS_LV2__
         free(msg);
#endif

Answer 5 · 2020-12-13T19:14:35.000Z

I see what's going on.

AFAIK m_pDisassembledROMMap = new stDisassembleRecord[MAX_ROM_SIZE]; is actually using heap memory, it's using new but it is too much for the PS3 (around 500MB). My bad.

Those changes are intended for a desktop debugger but are impacting the libretro core.

I have to rework this whole memory map.

Answer 6 · 2020-12-13T19:17:29.000Z

crystalct commented 4 years ago

Answer 7 · 2020-12-13T19:20:29.000Z

Thanks for the catch!

I'll try to fix this asap as it is definitely impacting Gearboy on all RetroArch systems with low memory, not only PS3.

Answer 8 · 2020-12-13T19:24:19.000Z

Thanks to keep Gearboy endian safe.... many (young) programmers don't even know about the existence of Big Endian - little endian problem.