driusan/de

Doesn't start

importnil opened this issue · 7 comments

driusan commented

I believe this should be fixed by 4a8c8c3. Can you update with go get -u github.com/driusan/de and let me know if it works?

importnil commented

Thanks, it starts. But it feels unresponsive, I literally can't do anything lol.
I tried to show that in a gif:
https://s.vadimyer.com/d995907a-60e7-4d5b-a5d5-be3031112012.gif

driusan commented

I just went back into Windows and made change e70ba26 (which I'd been meaning to do anyways) using the version that you say is unresponsive, and de didn't feel unresponsive to me, but I find Windows 10 generally to be unbearably slow even when I'm not doing anything, so it's hard to say if I just didn't notice because of that.

I have a feeling the above commit might fix your issue, because I wouldn't be surprised if allocating screen buffers has different performance under different drivers (or video cards) and it was getting called excessively.

importnil commented

No, that didn't fixed an issue :( I can record a video for better understanding, since everything else is okay and smooth.

driusan commented

Does 9c88241 help?

If not, there's one more optimization I can try tonight that I've been meaning to do anyways, but if neither of those work, I might need to see some profiling data to figure out where the bottleneck is.

importnil commented

Yes it works. It's far more smooth now, though mouse selection still looks a bit like "slowed".
P.S. Sorry for late reply.

driusan commented

b5a37dc is the last low-hanging fruit for optimizing the rendering which might improve it a little.

I'm closing this ticket (especially since it was originally about it crashing, not the performance), but if you notice that performance is/becomes unuseable, feel free to open a new ticket.