dropwizard/metrics

Since 4.1.23, metrics-bom manages dependencies that are not part of Dropwizard

wilkinsona opened this issue · 6 comments

wilkinsona commented

The changes made in f069a88 have resulted in metrics-bom managing non-Dropwizard dependencies. We noticed the problem when trying to upgrade Spring Boot to Dropwizard 4.1.23 from 4.1.22. It resulted in AssertJ jumping from 3.19.0 to 3.20.1.

Can metrics-bom please be restored to its previous state so that importing it only manages the versions of Dropwizard's own modules?

joschi commented

@wilkinsona Thanks for reporting this!

Could you please elaborate on the issue? io.dropwizard.metrics:metrics-bom:4.1.23 doesn't list any dependency in its dependencyManagement section which is not part of Dropwizard Metrics 4.1.23 itself and the commit you've linked to (#1967) only explicitly added the respective dependencies to the non-BOM sub-modules.

https://github.com/dropwizard/metrics/blob/v4.1.23/metrics-bom/pom.xml

diff --git v4.1.22/metrics-bom/pom.xml v4.1.23/metrics-bom/pom.xml
index f63fb6de..be1a3454 100644
--- metrics-bom/pom.xml
+++ metrics-bom/pom.xml
@@ -5,7 +5,7 @@
     <parent>
         <groupId>io.dropwizard.metrics</groupId>
         <artifactId>metrics-parent</artifactId>
-        <version>4.1.22</version>
+        <version>4.1.23</version>
     </parent>

     <artifactId>metrics-bom</artifactId>
joschi commented

Ah, it looks like the change came in via metrics-parent.

f069a88#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8

wilkinsona commented

Yeah, that's right. It's inherited via metrics-parent.

joschi commented

@wilkinsona @snicoll Dropwizard Metrics 4.1.24 and 4.2.2 should be available on Maven Central soon.

  • 👍1
  • ❤️1
wilkinsona commented

Thank you!

snicoll commented

Thanks @joschi, Spring Boot 2.4.x and 2.5.x have upgraded to that version.

  • 👍1