Virtual columns cause side effects (complete inserts switched on) and break gdpr-dump of Shopware 6

Question

Virtual columns cause side effects (complete inserts switched on) and break gdpr-dump of Shopware 6

Closed this issue 2 years ago · 7 comments

amenk commented 2 years ago

When virtual columns appear during dumping, complete-inserts are switched on.

With generated columns it causes also a "Column count doesn't match value count"

See here for more details: Smile-SA/gdpr-dump#78

amenk commented 2 years ago

Thank you

Answer 1 · 2022-11-10T14:24:51.000Z

I believe the culprit is this line:

https://github.com/ifsnop/mysqldump-php/blob/b232c2b6b2e250d716f936b0d11eda6bc2ec3df4/src/Ifsnop/Mysqldump/Mysqldump.php#L1274

Answer 2 · 2022-11-14T07:19:04.000Z

Maybe that setting value to true could be changed with some method e.g. disableCompleteInsert().

Could you provide a PR?

Answer 3 · 2022-11-14T08:22:38.000Z

The real problem is, that dumping tables with generated columns is breaking when complete inserts are on; so we will probably need to try to fix this one first. The side effect is just strange, but might be neglectable - I am wondering why they are being switched on when there are virtual columns.

Answer 4 · 2022-11-14T08:42:53.000Z

Dunno, that line comes from original ifsnop/mysqldump-php repo and I'm not familiar with whole complete-insert thing in general.

Answer 5 · 2022-11-14T14:35:16.000Z

will try to make a PR

Answer 6 · 2022-11-14T15:50:26.000Z

There is already test for GENERATED / VIRTUAL columns, which works. still need to make a minimal reproducible sample. Maybe it's related to the hex-blob option which is currently not set in the test. But simply setting it to true also does not make the test fail, maybe binary columns are needed....