drupal-composer/drupal-project

Should we commit console directory

mstrelan opened this issue · 7 comments

mstrelan commented

Drupal console installs a whole lot of translation files in to the console directory. Should this be gitignored or committed?

simesy commented

It depends on your project whether you want to ship custom console configuration.

mstrelan commented

Fair enough. I am thinking of ignoring console/language/console-en/translations but wonder if I should just ignore console/language.

simesy commented

I personally ignore all of it by default, i guess you'd know what you wanted and why?

mstrelan commented

I personally ignore all of it by default

Nice, that's what I wanted to hear.

i guess you'd know what you wanted and why?

If only that was true. I assume custom stuff can go somewhere in here and the stuff mentioned above looks more like third-party dependencies. It feels like committing /vendor. I guess if I ever stuck something custom under /console I'd know what needs to be kept, and in the meantime I can ignore the lot.

Wondering if something sensible should be added to the README or default .gitignore file.

simesy commented

So looks like it's storing settings equivalent to drushrc.php. you could pass arguments direct to console commands (which is what I do) or have defaults come from yml in that directory. Closest to docs i found was hechoendrupal/drupal-console#2725 (comment)

joestewart commented

Isn't #509 relevant?

  • 👍1
mstrelan commented

Thanks @joestewart apparently my search skills are lacking.